-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: correct a typo #30123
chore: correct a typo #30123
Conversation
chore: typo persistance -> persistence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to need code owner review from one of three people so I can't merge it, but looks good to me - thank you! |
It seems you need to bump the helm version. I think you can do this by running the pre-commit hooks. Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following:
Alternatively it is possible to run pre-commit by running pre-commit manually:
|
@mistercrunch unless there's a better command to bump the helm charts, we should copy-paste your CI failure logs about pre-commit to this GHA as well. I can do it sometime, if you're not in the mood to do so :) |
This comment was marked as outdated.
This comment was marked as outdated.
I applied pre-commit and update helm chart version to 0.12.13 |
chore: typo persistance -> persistence
SUMMARY
correct a typo persistance -> persistence
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
helm values.yaml comment change so don't need testing
ADDITIONAL INFORMATION